[TVMScript] Printer VarTable #12336
Merged
[TVMScript] Printer VarTable #12336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
23 tasks
yelite
force-pushed
the
tunip-irdocisifer-vartable
branch
6 times, most recently
from
6f46407
to
92c6499
Compare
yelite
force-pushed
the
tunip-irdocisifer-vartable
branch
from
92c6499
to
571c88c
Compare
Co-authored-by: Junru Shao <jshao@octoml.ai> Co-authored-by: Greg Bonik <gbonik@octoml.ai>
yelite
force-pushed
the
tunip-irdocisifer-vartable
branch
from
571c88c
to
4a33a98
Compare
junrushao
approved these changes
Aug 12, 2022
| * than IdDoc. It's useful when a variable is implicitly defined without a name, like | ||
| * the buf->data in TIR, which should be mapped to `AttrDoc(IdDoc("<buffer_name>"), "data")`. | ||
| * | ||
| * This function takes a DocFactory instead of Doc. It's because GetVarDoc needs to |
There was a problem hiding this comment.
To make sure I fully comprehend, would you mind elaborating a little bit with a short example? Thanks a lot!
There was a problem hiding this comment.
Sure. Assume DefineByDoc accepts a Doc instead of std::function<Doc()>. It will be more difficult to handle case like
c[k] = a[i] + a[j]
when we call the GetVarDoc for the first a and second a, we expect the returned Docs to be different objects and have different source_path. Therefore the VarTable needs to hold a function that returns Doc, rather than Doc itself.
I also update the doc, trying to better clarify it. Let me know if it still looks confusing.
There was a problem hiding this comment.
That makes sense to me! Thanks for your detailed explanation!
junrushao
pushed a commit
that referenced
this pull request
Aug 16, 2022
xinetzone
pushed a commit
to daobook/tvm
that referenced
this pull request
Nov 25, 2022
This PR: - Adds VarTable for the new TVMScript Printer Compared to the prototype version, this: - Removes unnecessary public methods. - GetObjectName - GetUniqueName - Add Frame parameter for `Define` methods. VarTable will add callback to Frame to remove variable when Frame exits. - Changes DocFactory from `ExprDoc(ObjectPath)` to `ExprDoc()` to simplify var definition. Tracking issue: apache#11912
xinetzone
pushed a commit
to daobook/tvm
that referenced
this pull request
Nov 25, 2022
This PR: - Adds IRDocsifier This PR is in draft state because it's branched off from a pending PR apache#12336 Tracking issue: apache#11912 Co-authored-by: Greg Bonik <gbonik@octoml.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
Compared to the prototype version, this:
Definemethods. VarTable will add callback to Frame to remove variable when Frame exits.ExprDoc(ObjectPath)toExprDoc()to simplify var definition.Tracking issue: #11912
cc @junrushao1994 @gbonik