[TIR] Add pass to check for out of bounds memory access #12352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a conservative static analysis that checks to see if any out of bounds array access occurs. It is not enabled by default.
Lunderberg
reviewed
Aug 10, 2022
added 2 commits
August 10, 2022 13:37
|
I'll take a look over the weekend |
AndrewZhaoLuo
approved these changes
Aug 22, 2022
| String DetailRenderTemplate() const final { | ||
| std::stringstream s; | ||
| for (const auto& oob : locations_) { | ||
| s << "Out of bounds memory access on buffer " << oob.buf->name << " dimension " |
There was a problem hiding this comment.
nit: It might be nice to have a test where you show the full rendered strings.
xinetzone
pushed a commit
to daobook/tvm
that referenced
this pull request
Nov 25, 2022
* [TIR] Add pass to check for out of bounds memory access This is a conservative static analysis that checks to see if any out of bounds array access occurs. It is not enabled by default. * formatting * manually construct local irmodule * update comment * fix bug in int_set
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a conservative static analysis that checks to see if any out of bounds array access occurs. It is not enabled by default.
@Lunderberg @AndrewZhaoLuo @jwfromm
cc @gigiblender