Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CMSIS-NN] Pad fusion with QNN Conv2D #12353

Merged
merged 5 commits into from
Aug 23, 2022
Merged

[CMSIS-NN] Pad fusion with QNN Conv2D #12353

merged 5 commits into from
Aug 23, 2022

Conversation

ashutosh-arm
Copy link
Contributor

@ashutosh-arm ashutosh-arm commented Aug 9, 2022 •
edited by github-actions bot
Loading

Pass that fuses nn.pad and qnn.conv2d for CMSIS-NN target.

cc @Mousius @areusch @grant-arm @lhutton1 @manupa-arm

@github-actions github-actions bot requested a review from Mousius August 9, 2022 21:41
SebastianBoblest
SebastianBoblest approved these changes Aug 10, 2022
View reviewed changes
python/tvm/relay/op/contrib/cmsisnn.py Outdated Show resolved Hide resolved
tests/python/contrib/test_cmsisnn/test_conv2d.py Outdated Show resolved Hide resolved
tests/python/contrib/test_cmsisnn/test_conv2d.py Outdated Show resolved Hide resolved
tests/python/contrib/test_cmsisnn/test_conv2d.py Outdated Show resolved Hide resolved
tests/python/contrib/test_cmsisnn/test_conv2d.py Outdated Show resolved Hide resolved
tests/python/contrib/test_cmsisnn/test_fuse_pads.py Outdated Show resolved Hide resolved
tests/python/contrib/test_cmsisnn/test_fuse_pads.py Outdated Show resolved Hide resolved
tests/python/contrib/test_cmsisnn/utils.py Outdated Show resolved Hide resolved
@github-actions github-actions bot requested a review from areusch August 10, 2022 16:19
lhutton1
lhutton1 reviewed Aug 11, 2022
View reviewed changes
Copy link
Contributor

@lhutton1 lhutton1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few comments / questions.. see what you think

src/relay/backend/contrib/cmsisnn/fuse_pads.cc Outdated Show resolved Hide resolved
src/relay/backend/contrib/cmsisnn/fuse_pads.cc Show resolved Hide resolved
tests/python/contrib/test_cmsisnn/test_fuse_pads.py Outdated Show resolved Hide resolved
src/relay/backend/contrib/cmsisnn/fuse_pads.cc Outdated Show resolved Hide resolved
tests/python/contrib/test_cmsisnn/test_conv2d.py Show resolved Hide resolved
src/relay/backend/contrib/cmsisnn/fuse_pads.cc Outdated Show resolved Hide resolved
src/relay/backend/contrib/cmsisnn/fuse_pads.cc Outdated Show resolved Hide resolved
lhutton1
lhutton1 reviewed Aug 18, 2022
View reviewed changes
Copy link
Contributor

@lhutton1 lhutton1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the improvements @ashutosh-arm, looks great! I just had a couple more small comments

python/tvm/relay/op/contrib/cmsisnn.py Show resolved Hide resolved
src/relay/backend/contrib/cmsisnn/fuse_pads.cc Show resolved Hide resolved
src/relay/backend/contrib/cmsisnn/fuse_pads.cc Outdated Show resolved Hide resolved
tests/python/contrib/test_cmsisnn/test_fuse_pads.py Show resolved Hide resolved
@ashutosh-arm
[CMSIS-NN] Added pass that fuses preceding nn.pad with qnn.conv2d
fa53405 
Change-Id: I2fd834dd93e7afdcc454c38700448e3f4d5eb0f5
@ashutosh-arm
Added docstrings, comments and chanegd names of variables
975606f 
Change-Id: I6073ce46aa1687aa68b3dc83c848dc5ec7e6d0e0
@ashutosh-arm
Separated out pattern matching with and without pads
e7d58fb 
Change-Id: If58a54bc61d88d899399e6ce0d74ce4e71e7da4c
@ashutosh-arm
Compressed recreating new call nodes for qnn.conv2d
29482e5 
Change-Id: I4e09cde765586a576e75b4a6f6fdd9419c1ebdae
@ashutosh-arm
Reused conv2d pattern matching checks
b0b48b3 
Change-Id: I1e032295668e68849a365da0dde28234c66cc056
lhutton1
lhutton1 approved these changes Aug 23, 2022
View reviewed changes
Copy link
Contributor

@lhutton1 lhutton1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates @ashutosh-arm, LGTM!

@lhutton1 lhutton1 merged commit 52779f1 into apache:main Aug 23, 2022
@lhutton1
Copy link
Contributor

Thanks @ashutosh-arm, @SebastianBoblest!

@cconvey cconvey mentioned this pull request Aug 29, 2022
Closed
@ashutosh-arm ashutosh-arm deleted the conv2d_pad_fusion branch August 31, 2022 11:30
@AndrewZhaoLuo AndrewZhaoLuo mentioned this pull request Oct 4, 2022
Closed
xinetzone pushed a commit to daobook/tvm that referenced this pull request Nov 25, 2022
@ashutosh-arm @xinetzone
[CMSIS-NN] Pad fusion with QNN Conv2D (apache#12353)
9974903 
Pass that fuses nn.pad and qnn.conv2d for CMSIS-NN target.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SebastianBoblest SebastianBoblest SebastianBoblest approved these changes

@lhutton1 lhutton1 lhutton1 approved these changes

@Mousius Mousius Awaiting requested review from Mousius

@areusch areusch Awaiting requested review from areusch

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ashutosh-arm @lhutton1 @SebastianBoblest