-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Profiler] Fix graph_executor_debug hang #12382
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For some operations such as `__nop` or `__copy` the measured inference time is equal to 0. In this case we are in infinite loop and we won't exit from it. Added new parameter `max_repeat_num` which specify the maximum number of repeats then the inference time is equal to 0. When we exceed this value then we will exit from a loop.
echuraev
force-pushed
the
echuraev/fix_profiler_hang
branch
from
August 11, 2022 14:30
da63b36
to
8067b1c
Compare
Icemist
reviewed
Aug 11, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks useful, a few comments.
СС @tkonolige may be interested in this too.
echuraev
force-pushed
the
echuraev/fix_profiler_hang
branch
4 times, most recently
from
August 12, 2022 09:09
ef7558c
to
08ffe3a
Compare
echuraev
force-pushed
the
echuraev/fix_profiler_hang
branch
from
August 12, 2022 09:44
08ffe3a
to
140d554
Compare
Icemist
approved these changes
Aug 12, 2022
tkonolige
approved these changes
Aug 12, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@echuraev thanks!
comaniac
added a commit
to awslabs/raf
that referenced
this pull request
Aug 15, 2022
comaniac
added a commit
to awslabs/raf
that referenced
this pull request
Aug 15, 2022
* [TVM] Update Submodule * [Compatible] Fix apache/tvm#12066 * [Compatible] Fix apache/tvm#12382 Co-authored-by: SubmoduleUpdaterBot <submodule-updater-bot@users.noreply.github.com> Co-authored-by: Cody Yu <comaniac0422@gmail.com>
xinetzone
pushed a commit
to daobook/tvm
that referenced
this pull request
Nov 25, 2022
For some operations such as `__nop` or `__copy` the measured inference time is equal to 0. In this case we are in infinite loop and we won't exit from it. Added new parameter `limit_zero_time_iterations ` which specify the maximum number of repeats then the inference time is equal to 0. When we exceed this value then we will exit from a loop.
mikeseven
pushed a commit
to mikeseven/tvm
that referenced
this pull request
Sep 27, 2023
For some operations such as `__nop` or `__copy` the measured inference time is equal to 0. In this case we are in infinite loop and we won't exit from it. Added new parameter `limit_zero_time_iterations ` which specify the maximum number of repeats then the inference time is equal to 0. When we exceed this value then we will exit from a loop.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some operations such as
__nop
or__copy
the measured inferencetime is equal to 0. In this case we are in infinite loop and we won't
exit from it. Added new parameter
max_repeat_num
which specify themaximum number of repeats then the inference time is equal to 0. When
we exceed this value then we will exit from a loop.
cc: @valmat07, @Icemist, @masahi