-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI] Assert some unittests are not skipped in CI #12436
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty great! This is a nice way to fix this without putting too much burden on developers. It’d be nice to see a end to end test in your tvm fork too
183f513
to
2c7c7ab
Compare
b63432a
to
d4e670c
Compare
…built branch on CI and reports in a comment.
3a3e1ca
to
29ccb5b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
general structure looks good, just a couple more small comments
29ccb5b
to
1d88434
Compare
1d88434
to
f3226c5
Compare
This PR adds a script that does a diff of skipped tests between the latest successful build on the main and the current branch. Then, it posts a comment with the report on the open PR. apache#11670
This PR adds a script that does a diff of skipped tests between the latest successful build on the main and the current branch. Then, it posts a comment with the report on the open PR.
#11670
@driazati @areusch
cc @Mousius