[CRT runtime] Fix memset of memory pool in PageMemoryManagerCreate #12437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kparzysz-quic
approved these changes
Aug 17, 2022
|
thanks @hugy718 ! |
xinetzone
pushed a commit
to daobook/tvm
that referenced
this pull request
Nov 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the memset during creation of memory manager. It should clear the whole memory pool, otherwise the next invocation will create a manager with some attributes using old values.
I found this issue when trying to call
tvm_runtime_createthe second time led to error. (my codes are similar toapps/bundle_deploy/bundle_static.c). Internal checking would fail due to manager attributes being only partially cleared.cc @areusch