Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove mutable default arguments in mlp_model #12546

Merged
merged 1 commit into from
Aug 23, 2022
Merged

Conversation

michalpiszczek
Copy link
Contributor

Removes mutable default arguments in python/tvm/meta_schedule/cost_model/mlp_model.py.

@michalpiszczek michalpiszczek changed the title Remove mutable defaults in mlp_model Remove mutable default arguments in mlp_model Aug 22, 2022
@michalpiszczek
Copy link
Contributor Author

cc @zxybazh @Kathryn-cat PTAL

Copy link
Member

@junrushao junrushao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Thanks for spotting this!

@Kathryn-cat
Copy link
Contributor

LGTM!

@michalpiszczek
Copy link
Contributor Author

michalpiszczek commented Aug 23, 2022

Thank you for the reviews @junrushao @Kathryn-cat @zxybazh!

@zxybazh zxybazh merged commit 8e95bba into apache:main Aug 23, 2022
xinetzone pushed a commit to daobook/tvm that referenced this pull request Nov 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants