[TOPI][Hexagon] Implement quantized elementwise for hexagon #12606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trahman-quic
force-pushed
the
trahman-quic/quant-elementwise
branch
from
b09ef6e
to
f24d303
Compare
trahman-quic
force-pushed
the
trahman-quic/quant-elementwise
branch
from
f24d303
to
0eb2d8b
Compare
trahman-quic
force-pushed
the
trahman-quic/quant-elementwise
branch
from
0eb2d8b
to
293888c
Compare
|
Hi, @mehrdadh @kparzysz-quic @TejashShah this PR is ready for review. Thank you |
jverma-quic
reviewed
Sep 1, 2022
|
@trahman-quic @jverma-quic thanks for the contribution and review! |
trahman-quic
force-pushed
the
trahman-quic/quant-elementwise
branch
from
c8d3750
to
4d7bc6e
Compare
trahman-quic
force-pushed
the
trahman-quic/quant-elementwise
branch
from
e2a7d85
to
6acc3b8
Compare
trahman-quic
force-pushed
the
trahman-quic/quant-elementwise
branch
from
9527f92
to
56eb957
Compare
jverma-quic
reviewed
Sep 8, 2022
trahman-quic
force-pushed
the
trahman-quic/quant-elementwise
branch
2 times, most recently
from
1d89d43
to
5d06698
Compare
trahman-quic
force-pushed
the
trahman-quic/quant-elementwise
branch
from
5d06698
to
f22ecdd
Compare
jverma-quic
approved these changes
Sep 8, 2022
Thank you @jverma-quic . |
kparzysz-quic
approved these changes
Sep 9, 2022
xinetzone
pushed a commit
to daobook/tvm
that referenced
this pull request
Nov 25, 2022
…2606) * [TOPI][Hexagon] Add test and schedule for uint8 resize2d * Fix correctness issue * Reformat * [TOPI][Hexagon] Implement quantized elementwise * Reformat * Address review comments * Reformat * Revert * Address review comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds implementation for quantized elementwise ops (add, subtract, multiply) for hexagon with support of broadcasting. The quantization method uses fixed-point number to replace floating point instructions. In addition to the implementation, it includes appropriate schedules for uint8 layout. It also adds test case for these ops in uint8 dtype.
cc @mehrdadh