[TIR] More hygenic TVM_SREF macros #12607
Conversation
Previously, the `TVM_SREF_TO_BLOCK`, `TVM_SREF_TO_FOR`, and `TVM_TYPE_AS` macros required both the input and output variables. The input variable name is useful for improving the error message returned, but the output variable name isn't necessary for this functionality, and prevents the macro from being used as part of an expression. * Generate an immediately-invoked lambda expression to allow for an independently-scoped `result` variable. * Use parentheses around the input argument, in case the sref is the result of an expression. * Update all call sites to remove the macro argument providing the first argument.
|
This is currently opened as a draft PR, to see if there are breakages that weren't caught, and whether there should be a rollover from the output-parameter version to the new version. It's only an internal macro, but it could cause additional merge conflicts with existing PRs. |
|
I think it's a perfect solution actually :-) |
|
The only reason that I didn't do so previously was being a bit afraid that the lambda cannot be inlined...CC: @tqchen |
|
Cool, cool! I wasn't sure if there were other benefits to the macro that I had been missing, and wanted to be careful about breakage when tromping on a less familiar part of the codebase. Regarding inlining, my understanding is that lambdas can always be inlined by the as-if rule, and their limited scope usually lets the compiler be more aggressive about inlining than for normal functions. I hadn't ever verified this from the assembly before, but a couple of quick godbolt comparisons (function call not marked inline, function call marked inline, immediately invoked lambda) confirm that lambdas can be inlined with the same gcc version/optimization settings as are used on TVM's CI. |
Previously, the `TVM_SREF_TO_BLOCK`, `TVM_SREF_TO_FOR`, and `TVM_TYPE_AS` macros required both the input and output variables. The input variable name is useful for improving the error message returned, but the output variable name isn't necessary for this functionality, and prevents the macro from being used as part of an expression. * Generate an immediately-invoked lambda expression to allow for an independently-scoped `result` variable. * Use parentheses around the input argument, in case the sref is the result of an expression. * Update all call sites to remove the macro argument providing the first argument.
Previously, the
TVM_SREF_TO_BLOCK,TVM_SREF_TO_FOR, andTVM_TYPE_ASmacros required both the input and output variables. The input variable name is useful for improving the error message returned, but the output variable name isn't necessary for this functionality, and prevents the macro from being used as part of an expression.Generate an immediately-invoked lambda expression to allow for an independently-scoped
resultvariable.Use parentheses around the input argument, in case the sref is the result of an expression.
Update all call sites to remove the macro argument providing the first argument.
cc @Hzfengsy @junrushao1994