-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace '> >' in templates with >>, NFC #12615
Merged
kparzysz-quic
merged 1 commit into
apache:main
from
kparzysz-quic:template-closing-brackets
Aug 26, 2022
Merged
Replace '> >' in templates with >>, NFC #12615
kparzysz-quic
merged 1 commit into
apache:main
from
kparzysz-quic:template-closing-brackets
Aug 26, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The problem with greedy lexing of >> as an operator was solved in C++11, and now templates no longer require spaces between >'s.
junrushao
approved these changes
Aug 26, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
driazati
pushed a commit
to driazati/tvm
that referenced
this pull request
Aug 26, 2022
The problem with greedy lexing of >> as an operator was solved in C++11, and now templates no longer require spaces between >'s.
driazati
pushed a commit
to driazati/tvm
that referenced
this pull request
Aug 26, 2022
The problem with greedy lexing of >> as an operator was solved in C++11, and now templates no longer require spaces between >'s.
driazati
pushed a commit
to driazati/tvm
that referenced
this pull request
Aug 29, 2022
The problem with greedy lexing of >> as an operator was solved in C++11, and now templates no longer require spaces between >'s.
driazati
pushed a commit
to driazati/tvm
that referenced
this pull request
Aug 30, 2022
The problem with greedy lexing of >> as an operator was solved in C++11, and now templates no longer require spaces between >'s.
driazati
pushed a commit
to driazati/tvm
that referenced
this pull request
Sep 1, 2022
The problem with greedy lexing of >> as an operator was solved in C++11, and now templates no longer require spaces between >'s.
driazati
pushed a commit
to driazati/tvm
that referenced
this pull request
Sep 1, 2022
The problem with greedy lexing of >> as an operator was solved in C++11, and now templates no longer require spaces between >'s.
driazati
pushed a commit
to driazati/tvm
that referenced
this pull request
Sep 6, 2022
The problem with greedy lexing of >> as an operator was solved in C++11, and now templates no longer require spaces between >'s.
driazati
pushed a commit
to driazati/tvm
that referenced
this pull request
Sep 6, 2022
The problem with greedy lexing of >> as an operator was solved in C++11, and now templates no longer require spaces between >'s.
areusch
pushed a commit
that referenced
this pull request
Sep 7, 2022
Replace '> >' in templates with >>, NFC (#12615) The problem with greedy lexing of >> as an operator was solved in C++11, and now templates no longer require spaces between >'s. Co-authored-by: Krzysztof Parzyszek <kparzysz@quicinc.com>
xinetzone
pushed a commit
to daobook/tvm
that referenced
this pull request
Nov 25, 2022
The problem with greedy lexing of >> as an operator was solved in C++11, and now templates no longer require spaces between >'s.
xinetzone
pushed a commit
to daobook/tvm
that referenced
this pull request
Nov 25, 2022
Replace '> >' in templates with >>, NFC (apache#12615) The problem with greedy lexing of >> as an operator was solved in C++11, and now templates no longer require spaces between >'s. Co-authored-by: Krzysztof Parzyszek <kparzysz@quicinc.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem with greedy lexing of
>>
as an operator was solved in C++11, and now templates no longer require spaces between>
's.