Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MetaSchedule][UX] Convenient Object Creation #12643

Merged

Conversation

junrushao
Copy link
Member

@junrushao junrushao commented Aug 30, 2022

This PR introduces a set of .create methods making it easier to create
MetaSchedule objects.

For example:

ms.database.JSONDatabase(...)
ms.database.create("json")

ms.runner.RPCRunner(...)
ms.runner.create("rpc")

Besides, this PR allows JSONDatabase to be created via work_dir:

db = ms.database.create("json", work_dir="/path/to/db/")
db = ms.database.create(work_dir="/path/to/db/")  # or even simpler

cc @Hzfengsy @junrushao1994

@junrushao junrushao force-pushed the feature/2022-08-29/easy-create-objs branch from 54d0851 to 6d30617 Compare September 2, 2022 01:16
@junrushao junrushao marked this pull request as ready for review September 2, 2022 01:16
@junrushao
Copy link
Member Author

@junrushao junrushao force-pushed the feature/2022-08-29/easy-create-objs branch from 6d30617 to c3df66e Compare September 2, 2022 01:53
Copy link
Contributor

@MasterJH5574 MasterJH5574 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty to me! Thanks @junrushao for bringing the convenience!

This PR introduces a set of `.create` methods making it easier to create
MetaSchedule objects.

For example:

```python
ms.database.JSONDatabase(...)
ms.database.create("json")

ms.runner.RPCRunner(...)
ms.runner.create("rpc")
```

Besides, this PR allows `JSONDatabase` to be created via `work_dir`:

```python
db = ms.database.create("json", work_dir="/path/to/db/")
db = ms.database.create(work_dir="/path/to/db/")  # or even simpler
```
@junrushao junrushao force-pushed the feature/2022-08-29/easy-create-objs branch from c3df66e to 6aa8638 Compare September 2, 2022 05:13
@junrushao junrushao merged commit bb56f2a into apache:main Sep 2, 2022
xinetzone pushed a commit to daobook/tvm that referenced this pull request Nov 25, 2022
This PR introduces a set of `.create` methods making it easier to create
MetaSchedule objects.

For example:

```python
ms.database.JSONDatabase(...)
ms.database.create("json")

ms.runner.RPCRunner(...)
ms.runner.create("rpc")
```

Besides, this PR allows `JSONDatabase` to be created via `work_dir`:

```python
db = ms.database.create("json", work_dir="/path/to/db/")
db = ms.database.create(work_dir="/path/to/db/")  # or even simpler
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants