[Frontend][Paddle] Fix op in paddle did't transmit layout information #12658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ayout information
jiangjiajun
approved these changes
Aug 31, 2022
|
So, any thoughts on my question? @jiangjiajun |
|
@blackkker Thanks for fixing the data format problem, but I think this only work for operator However, the data format Anyway, this need to be fixed or assert in the frontend, I will send another pull request to handle |
|
Glad to get your reply, if the paddle framework discourages the use of NHWC, then some fixed or assert need to be added. Also may be an instruction to be added to warn user not to do it too. |
vinx13
approved these changes
Sep 9, 2022
xinetzone
pushed a commit
to daobook/tvm
that referenced
this pull request
Nov 25, 2022
…apache#12658) [Frontend][Paddle] Fix adaptive_avg_pool2d in paddle did't transmit layout information
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #12645.
I noticed that in the front-end conversion of paddle, all operators do not pass data_format information.
I want to know whether data_format needs to be passed, or the operators in the paddle model are all set according to the default layout of the
python/tvm/relay/op/nn/nn.py? And the author of #12645 should not diy the layout ?Please let me know if anything is wrong.