Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MetaSchedule] Relax conditions of rule Cross-Thread Reduction #12825

Merged

Conversation

MasterJH5574
Copy link
Contributor

This PR relaxes the conditions of Meta-Schedule schedule rule CrossThreadReduction. The rules are previously a bit over-strict, and some workloads with small reduction loop length are unable to be optimized by cross-thread reduction automatically. In this PR, we relax the rules so that such workloads can be optimized.

cc @junrushao

@junrushao
Copy link
Member

The only question from me is: is it going to make the search space smaller if rfactor or cross-thread reduction is improperly applied? If not, we can get it in

@MasterJH5574
Copy link
Contributor Author

The only question from me is: is it going to make the search space smaller if rfactor or cross-thread reduction is improperly applied? If not, we can get it in

@junrushao This PR is going to make the search space larger for workloads which have small reduction loop length. Previously, the transformations (rfactor or cross-thread reduction) are not applied to these workloads at all. The transformations are not improperly applied.

Copy link
Member

@junrushao junrushao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the clarification! LGTM!

@junrushao junrushao merged commit d1871a6 into apache:main Sep 18, 2022
xinetzone pushed a commit to daobook/tvm that referenced this pull request Nov 25, 2022
…e#12825)

This PR relaxes the conditions of Meta-Schedule schedule rule CrossThreadReduction. The rules are previously a bit over-strict, and some workloads with small reduction loop length are unable to be optimized by cross-thread reduction automatically. In this PR, we relax the rules so that such workloads can be optimized.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants