-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Hexagon] [runtime] VTCM Allocator #12947
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janetsc
changed the title
[WIP] VTCM Allocator
[WIP] [Hexagon] [runtime] VTCM Allocator
Sep 29, 2022
@tvm-bot rerun |
janetsc
commented
Sep 30, 2022
janetsc
changed the title
[WIP] [Hexagon] [runtime] VTCM Allocator
[Hexagon] [runtime] VTCM Allocator
Oct 1, 2022
Lunderberg
reviewed
Oct 3, 2022
kparzysz-quic
approved these changes
Oct 3, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
nverke
reviewed
Oct 3, 2022
xinetzone
pushed a commit
to daobook/tvm
that referenced
this pull request
Nov 25, 2022
Adds a VTCM Memory Pool class, which allocates the largest contiguous buffer possible within 1 page upon construction. Allocations and free space are maintained in two lists. Buffers that align on 2k size boundaries will choose the smallest open buffer which will satisfy the request. Non-aligned buffers will be allocated from the end of the free space. HexagonBuffer will use this pool to service VTCM scope requests, replacing the individual calls to allocated the memory on separate pages. The pool is created and destroyed in the device API Acquire/ReleaseResources. Adds unit tests to exercise edge cases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a VTCM Memory Pool class, which allocates the largest contiguous buffer possible within 1 page upon construction.
Allocations and free space are maintained in two lists. Buffers that align on 2k size boundaries will choose the smallest open buffer which will satisfy the request. Non-aligned buffers will be allocated from the end of the free space.
HexagonBuffer will use this pool to service VTCM scope requests, replacing the individual calls to allocated the memory on separate pages.
The pool is created and destroyed in the device API Acquire/ReleaseResources.
Adds unit tests to exercise edge cases.
cc: @supersat @adstraw