Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MetaSchedule][UX] Support Interactive Performance Table Printing in Notebook #13006

Merged

Conversation

zxybazh
Copy link
Member

@zxybazh zxybazh commented Oct 7, 2022

This PR further addes interactive table printing functionality following #12866, now performance table are print in dataframe style if running in jupyter notebook. Sample notebook see here
image

CC @junrushao

@zxybazh zxybazh marked this pull request as ready for review October 7, 2022 00:22
@zxybazh zxybazh force-pushed the feature/2022-10-06/notebook-dataframe branch from 7bd953f to 4ae69f8 Compare October 7, 2022 22:35
@zxybazh
Copy link
Member Author

zxybazh commented Oct 11, 2022

Ready for review and the current logger can:

  • In console: clear screen logging, print out table to file and console.
  • In notebook: clear notebook logging, print out table in text format on logging file and interactively on notebook.

@junrushao
Copy link
Member

CC @MasterJH5574 @spectrometerHBH would you like to review?

Copy link
Contributor

@MasterJH5574 MasterJH5574 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tvm-bot
Copy link
Collaborator

tvm-bot commented Oct 13, 2022

Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.

Generated by tvm-bot

@zxybazh zxybazh force-pushed the feature/2022-10-06/notebook-dataframe branch from 531bee8 to 14eb5eb Compare October 14, 2022 23:58
Copy link
Contributor

@MasterJH5574 MasterJH5574 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm very good with this now! Thanks @zxybazh for supporting the nice-looking table printing!

@MasterJH5574 MasterJH5574 merged commit 71f32ca into apache:main Oct 15, 2022
xinetzone pushed a commit to daobook/tvm that referenced this pull request Nov 10, 2022
…Notebook (apache#13006)

* Support interactive table printing.

* Rebase.

* Fix jupyter outputs.

* Fix CI.

* fix CI.

* Change file to filename.

* Address issues.
xinetzone pushed a commit to daobook/tvm that referenced this pull request Nov 25, 2022
…Notebook (apache#13006)

* Support interactive table printing.

* Rebase.

* Fix jupyter outputs.

* Fix CI.

* fix CI.

* Change file to filename.

* Address issues.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants