[TIR][Arith] Support negative coeff in ModularSet #13081
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.
Generated by tvm-bot |
|
This was originally discovered in a failing unit test for #13024. An unrolled loop produced a |
Prior to this commit, any use of negative coefficients in `ModularSet` would result in an error. This included cases where a constraint is being entered, such as `floormod(i, -2)==0` appearing as the condition of an if/else block. These negative indices can also arise as intermediate simplification steps produced by `CanonicalSimplifier`, such as `floormod(-i,2)` being canonicalized to `floormod(i,-2)`. This commit adds support for negative coefficients in `ModularSet`, using the same sign convention as is used by `CanonicalSimplifier` for negative denominators, and adds unit tests to verify that sign convention.
Lunderberg
force-pushed
the
modular_set_negative_arg
branch
from
b76c70a
to
297b3af
Compare
|
Rebasing onto main to get the bug fix from #13067 |
areusch
added
needs-triage
vinx13
reviewed
Oct 21, 2022
| @@ -97,6 +97,8 @@ def test_split_index_simplify(): | |||
| # cannot simplify mixed case, unless we canonicalize into one mode. | |||
| ck.verify(tdiv(x, 6) * 2 + tmod(fld(x, 3), 2), tdiv(x, 6) * 2 + tmod(fld(x, 3), 2)) | |||
|
|
|||
| ck.verify(tmod(-x, 2), tmod(x, -2) * -1) | |||
There was a problem hiding this comment.
does this cover modular set analysis?
There was a problem hiding this comment.
This test only covers the CanonicalSimplify behavior of negative indices, but the ModularSet's behavior should be consistent with the sign convention in CanonicalSimplify. Since CanonicalSimplify's sign convention for negative indices wasn't checked by any test I could find, I wanted to add a test for its behavior.
jwfromm
approved these changes
Oct 27, 2022
xinetzone
pushed a commit
to daobook/tvm
that referenced
this pull request
Nov 10, 2022
Prior to this commit, any use of negative coefficients in `ModularSet` would result in an error. This included cases where a constraint is being entered, such as `floormod(i, -2)==0` appearing as the condition of an if/else block. These negative indices can also arise as intermediate simplification steps produced by `CanonicalSimplifier`, such as `floormod(-i,2)` being canonicalized to `floormod(i,-2)`. This commit adds support for negative coefficients in `ModularSet`, using the same sign convention as is used by `CanonicalSimplifier` for negative denominators, and adds unit tests to verify that sign convention.
xinetzone
pushed a commit
to daobook/tvm
that referenced
this pull request
Nov 25, 2022
Prior to this commit, any use of negative coefficients in `ModularSet` would result in an error. This included cases where a constraint is being entered, such as `floormod(i, -2)==0` appearing as the condition of an if/else block. These negative indices can also arise as intermediate simplification steps produced by `CanonicalSimplifier`, such as `floormod(-i,2)` being canonicalized to `floormod(i,-2)`. This commit adds support for negative coefficients in `ModularSet`, using the same sign convention as is used by `CanonicalSimplifier` for negative denominators, and adds unit tests to verify that sign convention.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit, any use of negative coefficients in
ModularSetwould result in an error. This included cases where a constraint is being entered, such asfloormod(i, -2)==0appearing as the condition of an if/else block. These negative indices can also arise as intermediate simplification steps produced byCanonicalSimplifier, such asfloormod(-i,2)being canonicalized tofloormod(i,-2).This commit adds support for negative coefficients in
ModularSet, using the same sign convention as is used byCanonicalSimplifierfor negative denominators, and adds unit tests to verify that sign convention.