[Hexagon] Fix correctness error in conv2d hvx

[quic-sanirudh]

The output vector was not initialized to zero and that was causing incorrect output on target intermittently, but was always working on simulator. This patch fixes the error and enables the test case again

[tvm-bot]

Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.

• cc @mehrdadh _{See #10317 for details}
• Built docs for commit b4505e4 can be found here.

_{Generated by tvm-bot}

[janetsc]

I'm still seeing some failures with this change on our HDK. What is your hardware setup?

For example:

TestConv2dIntrin.test_conv2d[offset0x0-nhwc1x14x6x3-hwio3x3x3x64-stride1x1]
...
E AssertionError:
E Not equal to tolerance rtol=0.05, atol=0.05
E
E Mismatched elements: 1536 / 3072 (50%)
E Max absolute difference: 282.5
E Max relative difference: 57.4
E x: array([[[[ 5.51 , 5.754, 5.863, ..., 22.42 , 26.55 , 22.17 ],
E [ 5.88 , 7.195, 6.836, ..., 19.3 , 25.8 , 19.23 ],
E [ 6.1 , 6.68 , 6.62 , ..., 37.3 , 49.7 , 36.72 ],...
E y: array([[[[5.52 , 5.746, 5.86 , ..., 6.41 , 6.758, 5.918],
E [5.867, 7.19 , 6.832, ..., 5.484, 7.34 , 4.094],
E [6.098, 6.67 , 6.62 , ..., 5.605, 7.156, 4.508],...

[quic-sanirudh]

I'm still seeing some failures with this change on our HDK. What is your hardware setup?

For example:

TestConv2dIntrin.test_conv2d[offset0x0-nhwc1x14x6x3-hwio3x3x3x64-stride1x1] ... E AssertionError: E Not equal to tolerance rtol=0.05, atol=0.05 E E Mismatched elements: 1536 / 3072 (50%) E Max absolute difference: 282.5 E Max relative difference: 57.4 E x: array([[[[ 5.51 , 5.754, 5.863, ..., 22.42 , 26.55 , 22.17 ], E [ 5.88 , 7.195, 6.836, ..., 19.3 , 25.8 , 19.23 ], E [ 6.1 , 6.68 , 6.62 , ..., 37.3 , 49.7 , 36.72 ],... E y: array([[[[5.52 , 5.746, 5.86 , ..., 6.41 , 6.758, 5.918], E [5.867, 7.19 , 6.832, ..., 5.484, 7.34 , 4.094], E [6.098, 6.67 , 6.62 , ..., 5.605, 7.156, 4.508],...

Oh that's surprising. I ran it multiple times on lahaina (v68) devices and never got any errors. I'll try to run it on other devices and see if I can reproduce this error.

[quic-sanirudh]

Hi @janetsc, could you please share your device details, as I'm unable to reproduce the issue on my devices. I'm testing on v68 (lahaina) devices, and the tests are always passing for me on these devices, so need a little bit of help in reproducing the error you're seeing.

[janetsc]

I re-ran on a v69 device, and it is now passing. Sorry for the confusion previously - it is possible something didn't get updated on the device when I tried before. I will sign off. Thanks!

[janetsc]

Tested and verified - looks good

[quic-sanirudh]

Tested and verified - looks good

Thanks for the review