Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[microTVM] Fix RPC session close on runtime side #13310

Merged
merged 3 commits into from
Nov 8, 2022

Conversation

mehrdadh
Copy link
Member

@mehrdadh mehrdadh commented Nov 7, 2022

Currently, the RPC session on C/C++ side does not know if the session was closed on python side which causes extra read/write on transport while the session is already closed. This PR reuses the hexagon approach in microTVM to shutdown the RPC session.

@tvm-bot
Copy link
Collaborator

tvm-bot commented Nov 7, 2022

Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.

Generated by tvm-bot

Copy link
Contributor

@gromero gromero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@gromero
Copy link
Contributor

gromero commented Nov 7, 2022

CI / Android failed. I'm re-triggering.

@gromero
Copy link
Contributor

gromero commented Nov 7, 2022

@tvm-bot rerun

@gromero gromero merged commit e43841d into apache:main Nov 8, 2022
@gromero
Copy link
Contributor

gromero commented Nov 8, 2022

@mehrdadh Thank you. The change is now merged.

@mehrdadh mehrdadh deleted the micro/fix_rpc_close_issue branch November 8, 2022 16:36
xinetzone pushed a commit to daobook/tvm that referenced this pull request Nov 10, 2022
Currently, the RPC session on C/C++ side does not know if the session  
was closed on Python side which causes extra read/write on transport   
while the session is already closed. This commit reuses the Hexagon    
approach in microTVM to shutdown the RPC session.
xinetzone pushed a commit to daobook/tvm that referenced this pull request Nov 25, 2022
Currently, the RPC session on C/C++ side does not know if the session  
was closed on Python side which causes extra read/write on transport   
while the session is already closed. This commit reuses the Hexagon    
approach in microTVM to shutdown the RPC session.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants