Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Codegen] Fix CUDA codegen for int64 Ramp #13382

Merged
merged 1 commit into from
Nov 15, 2022

Conversation

vinx13
Copy link
Member

@vinx13 vinx13 commented Nov 14, 2022

CUDA codegen fails to generate T.ramp(T.int64(0), T.int64(1), 2)] correctly.
This is a legal IR that appears after a recent commit to simplify cast and ramp. Fixed #13379.

cc @comaniac @junrushao

@tvm-bot
Copy link
Collaborator

tvm-bot commented Nov 14, 2022

Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.

  • No users to tag found in teams: codegen See #10317 for details
  • Built docs for commit 00a42e5 can be found here.

Generated by tvm-bot

Copy link
Contributor

@comaniac comaniac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the quick fix.

@junrushao
Copy link
Member

junrushao commented Nov 14, 2022

Fixes #13379

@comaniac comaniac merged commit 3aa16f7 into apache:main Nov 15, 2022
@comaniac
Copy link
Contributor

Thanks @vinx13 @junrushao

comaniac added a commit to awslabs/raf that referenced this pull request Nov 15, 2022
xinetzone pushed a commit to daobook/tvm that referenced this pull request Nov 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] no suitable user-defined conversion from "int2" to "longlong2" exists
4 participants