[COLLAGE] Add more customization to support more targets #13450

krishnaraj36 · 2022-11-21T13:12:41Z

Added custom cost module to provide a provision to incorporate custom cost estimator python function instead using default cost function.
eg: cost_estimator = CustomCostEstimator(py_fn_estimator="tvm.relay.collage.opencl_cost_estimator")
mod = CollagePartition(config, cost_estimator=cost_estimator)(mod)
Added provision to select BYOC fusion style for all compiler target.
eg : config = { "relay.collage.byoc_fusion_style": ["compiler.NoFusion", "compiler.TVMFusion"]}
ctxt = tvm.transform.PassContext(config=config)

tvm-bot · 2022-11-21T13:12:44Z

Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.

No users to tag found in teams: collage _{See #10317 for details}
Built docs for commit 912bf6d can be found here.

_{Generated by tvm-bot}

srkreddy1238 · 2022-12-05T09:34:46Z

@mbs-octoml can you take a look on this PR ?

tests/python/contrib/test_clml/menangerie.py

tests/python/contrib/test_clml/test_adreno_collage_targets.py

1. Added custom cost module to provide a provision to incorporate custom cost estimator python function instead using default cost function. eg: cost_estimator = CustomCostEstimator(py_fn_estimator="tvm.relay.collage.opencl_cost_estimator") mod = CollagePartition(config, cost_estimator=cost_estimator)(mod) 2. Added provision to select BYOC fusion style for all compiler target. eg : config = { "relay.collage.byoc_fusion_style": ["compiler.NoFusion", "compiler.TVMFusion"]} ctxt = tvm.transform.PassContext(config=config)

srkreddy1238

LGTM.

srkreddy1238 · 2023-01-04T05:09:53Z

@tqchen Do we have moderator for Collage ?

srkreddy1238 · 2023-01-05T04:24:40Z

@masahi any moderator for Collage ?

masahi · 2023-01-05T04:42:11Z

Not sure and I'm not familiar with it either. But I can take care of this.

krishnaraj36 · 2023-01-05T08:23:43Z

@masahi :
I have resolved all merge conflicts on this PR, can you please review and merge this PR.

krishnaraj36 · 2023-01-06T05:25:57Z

Please remove typos and obvious grammar errors. I found many just looking over the code briefly. Please go through your change.

Also remove TODO(mbs) stuff.

@masahi
I have fixed the most of typo error and removed TODO (mbs), Please review and let me know your feedback.

src/relay/collage/custom_cost_estimator.cc

src/relay/collage/custom_cost_estimator.h

tests/python/contrib/test_clml/menangerie.py

src/relay/collage/gather_partition_specs.cc

tests/python/contrib/test_clml/test_adreno_collage_targets.py

src/relay/collage/gather_partition_specs.cc

krishnaraj36 · 2023-01-09T16:51:16Z

@masahi
Thank you for feedback.
I have added modification to code as per your suggestion and wrote clarification for your few quarries.
Please review again and let me know you feedback.

src/relay/collage/gather_partition_specs.cc

src/relay/collage/utils.cc

masahi · 2023-01-09T21:37:32Z

tests/python/contrib/test_clml/test_adreno_collage_targets.py

+
+    logging.info(f"Invoking runner...")
+
+    os.system(f"python3 {runner_path}")


That doesn't answer my question. Why not, instead of runner_template thing and invoke the string with os.system, wrap the same functionality in a normal function and call it however time you want.

tests/python/contrib/test_clml/test_adreno_collage_targets.py

krishnaraj36 · 2023-01-10T06:31:49Z

@masahi
Thanks for feedback, I have added the modification to the code as per your suggestion.
Please review and let me know your feedback.

krishnaraj36

I have added the modification to the code as per your suggestion.
Please review and let me know your feedback.

* [COLLAGE] Add more customization to support more targets 1. Added custom cost module to provide a provision to incorporate custom cost estimator python function instead using default cost function. eg: cost_estimator = CustomCostEstimator(py_fn_estimator="tvm.relay.collage.opencl_cost_estimator") mod = CollagePartition(config, cost_estimator=cost_estimator)(mod) 2. Added provision to select BYOC fusion style for all compiler target. eg : config = { "relay.collage.byoc_fusion_style": ["compiler.NoFusion", "compiler.TVMFusion"]} ctxt = tvm.transform.PassContext(config=config) * Fix the lint errors * Fix the lint error whitespace * Fix the lint error tabs * Fix the lint error tabs * Fix the lint error tabs * move the clml collage test case to test_clml * Fix lint error whitespace * Fix the import error * Fix the envirnoment var and import * Add comments * Add clml preprocess module in cost estimator * Fix whitespace lint error * Fix whitespace lint error * Fix whitespace lint error * Fix the comments and removed unwanted code * Fix whitespace error * Removed Todo comments * Removed TODO comments * Updated naming convension * Fix typo error * Fixe the typo error * Corrected typo error * Corrected typo error * Removed unused and fix typo error * Removed redundent code and optimize the code * Fix the lint error * Fix whitespace lint error * Removed Prints in file * Fix lint error * Fix lint error * Removed runner template in test script * Fix the lint error * Fix lint error * Fix lint error * Fix the lint error * Fix the lint error Co-authored-by: kvegiraj <kvegiraj@qti.qualcomm.com>

krishnaraj36 force-pushed the collage_update branch from da3efbf to 2c2e9cc Compare November 29, 2022 16:11

srkreddy1238 self-requested a review December 5, 2022 09:33

srkreddy1238 requested a review from mbaret December 5, 2022 09:35

srkreddy1238 requested changes Dec 13, 2022

View reviewed changes

tests/python/contrib/test_clml/menangerie.py Outdated Show resolved Hide resolved

tests/python/contrib/test_clml/test_adreno_collage_targets.py Outdated Show resolved Hide resolved

kvegiraj added 16 commits December 12, 2022 23:15

Fix the lint errors

8a8b622

Fix the lint error whitespace

8c509c5

Fix the lint error tabs

2c54172

Fix the lint error tabs

c707bd9

Fix the lint error tabs

1b4114b

move the clml collage test case to test_clml

f8b6609

Fix lint error whitespace

a61b5b0

Fix the import error

40bd214

Fix the envirnoment var and import

021e542

Add comments

4742574

Add clml preprocess module in cost estimator

859845a

Fix whitespace lint error

ecd6901

Fix whitespace lint error

30acd26

Fix whitespace lint error

7b3fdf3

Fix the comments and removed unwanted code

cd0e178

krishnaraj36 force-pushed the collage_update branch from 4ab2135 to cd0e178 Compare December 13, 2022 07:17

Fix whitespace error

5cbd53d

srkreddy1238 approved these changes Dec 15, 2022

View reviewed changes

Merge branch 'main' into collage_update

0414eae

krishnaraj36 added 4 commits January 5, 2023 16:10

Removed TODO comments

a935ae9

Updated naming convension

056885e

Fix typo error

5804b08

Fixe the typo error

85b25cb

masahi requested changes Jan 7, 2023

View reviewed changes

krishnaraj36 and others added 6 commits January 9, 2023 09:57

Corrected typo error

d5e10f4

Corrected typo error

5f2bd89

Removed unused and fix typo error

fb2181d

Removed redundent code and optimize the code

bd42a90

Fix the lint error

b5ca5c0

Fix whitespace lint error

513366a

masahi requested changes Jan 9, 2023

View reviewed changes

krishnaraj36 and others added 4 commits January 10, 2023 10:11

Removed Prints in file

af47069

Fix lint error

2e840f1

Fix lint error

f02d639

Removed runner template in test script

a72b61e

krishnaraj36 added 5 commits January 10, 2023 12:05

Fix the lint error

6951d46

Fix lint error

7367a71

Fix lint error

d2a7274

Fix the lint error

9330d4b

Fix the lint error

4a3d5a2

krishnaraj36 commented Jan 10, 2023

View reviewed changes

masahi approved these changes Jan 10, 2023

View reviewed changes

masahi merged commit db920dd into apache:main Jan 10, 2023

krishnaraj36 deleted the collage_update branch January 10, 2023 16:05

ysh329 mentioned this pull request Apr 17, 2023

[Release] v0.12.0 Release Candidate Notes #14645

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[COLLAGE] Add more customization to support more targets #13450

[COLLAGE] Add more customization to support more targets #13450

krishnaraj36 commented Nov 21, 2022

tvm-bot commented Nov 21, 2022 •

edited

Loading

srkreddy1238 commented Dec 5, 2022

srkreddy1238 left a comment

srkreddy1238 commented Jan 4, 2023

srkreddy1238 commented Jan 5, 2023

masahi commented Jan 5, 2023

krishnaraj36 commented Jan 5, 2023

krishnaraj36 commented Jan 6, 2023 •

edited

Loading

krishnaraj36 commented Jan 9, 2023 •

edited

Loading

masahi Jan 9, 2023

krishnaraj36 commented Jan 10, 2023

krishnaraj36 left a comment


		logging.info(f"Invoking runner...")

		os.system(f"python3 {runner_path}")

[COLLAGE] Add more customization to support more targets #13450

[COLLAGE] Add more customization to support more targets #13450

Conversation

krishnaraj36 commented Nov 21, 2022

tvm-bot commented Nov 21, 2022 • edited Loading

srkreddy1238 commented Dec 5, 2022

srkreddy1238 left a comment

Choose a reason for hiding this comment

srkreddy1238 commented Jan 4, 2023

srkreddy1238 commented Jan 5, 2023

masahi commented Jan 5, 2023

krishnaraj36 commented Jan 5, 2023

krishnaraj36 commented Jan 6, 2023 • edited Loading

krishnaraj36 commented Jan 9, 2023 • edited Loading

masahi Jan 9, 2023

Choose a reason for hiding this comment

krishnaraj36 commented Jan 10, 2023

krishnaraj36 left a comment

Choose a reason for hiding this comment

tvm-bot commented Nov 21, 2022 •

edited

Loading

krishnaraj36 commented Jan 6, 2023 •

edited

Loading

krishnaraj36 commented Jan 9, 2023 •

edited

Loading