-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TIR] Fix dtype mismatch error due to LetStmt #13710
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.
Generated by tvm-bot |
masahi
changed the title
Dtype legalize fix let
[TIR] Fix dtype mismatch error due to LetStmt
Jan 5, 2023
tqchen
approved these changes
Jan 6, 2023
masahi
commented
Jan 6, 2023
Hzfengsy
approved these changes
Jan 6, 2023
masahi
force-pushed
the
dtype-legalize-fix-let
branch
from
January 6, 2023 11:47
e41adfa
to
c7e4559
Compare
vinx13
reviewed
Jan 6, 2023
vinx13
approved these changes
Jan 7, 2023
fzi-peccia
pushed a commit
to fzi-peccia/tvm
that referenced
this pull request
Mar 27, 2023
* [TIR] Fix dtype mismatch error due to LetStmt * add comment * improve letstmt visitor * remove SubstituteWithDataTypeLegalization * consolidate vmap look up logic in the base class
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, even if the dtype of the rhs of
LetStmt
is casted to int64, the bound variable doesn't get updated. This results in the following invalid IR to be generated:cc @vinx13