Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove tutorials CMSIS dependency when not needed #13762

Merged
merged 2 commits into from
Jan 12, 2023

Conversation

NicolaLancellotti
Copy link
Contributor

Pr #13656 added support for CMSIS NN from a new GitHub location.
The project at the new location uses a new header arm_acle.h which is not always present.
This pr removes the CMSIS dependency for the tutorials in gallery/how_to/work_with_microtvm when the tutorials are run with Zephyr.
We need this pr, otherwise, when the docker image will be updated there will be errors, due to the missing header.

@tvm-bot
Copy link
Collaborator

tvm-bot commented Jan 11, 2023

Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.

  • No users to auto-tag found, no teams are specified in PR title See #10317 for details

Generated by tvm-bot

@NicolaLancellotti
Copy link
Contributor Author

NicolaLancellotti commented Jan 11, 2023

@ashutosh-arm, @mehrdadh

@NicolaLancellotti NicolaLancellotti changed the title Remove tutorials CMSIS dependencies when not needed Remove tutorials CMSIS dependency when not needed Jan 11, 2023
@mehrdadh mehrdadh requested a review from guberti January 11, 2023 18:30
Copy link
Member

@guberti guberti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, but do these tutorials still need to include instructions to install CMSIS? I'd love to remove this from micro_aot.py, micro_autotune.py, and micro_tflite.py if we can.

######################################################################
#
#     .. include:: ../../../../gallery/how_to/work_with_microtvm/install_dependencies.rst
#

Change-Id: Ic844422c74855f774b97ea57c6cb6eac2236e29b
@NicolaLancellotti
Copy link
Contributor Author

This looks good, but do these tutorials still need to include instructions to install CMSIS? I'd love to remove this from micro_aot.py, micro_autotune.py, and micro_tflite.py if we can.

######################################################################
#
#     .. include:: ../../../../gallery/how_to/work_with_microtvm/install_dependencies.rst
#

Done. Thanks for the review!

@@ -1,35 +0,0 @@
.. Licensed to the Apache Software Foundation (ASF) under one
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't remove this file as we will need it in future tutorials

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I re-added the file and edited it adding the commands to download CMSIS NN from the new GitHub location.

Change-Id: Idbaada0753a9d46cfd94f71fcb30c7f7a8a1d17d
@mehrdadh mehrdadh requested a review from guberti January 12, 2023 20:12
Copy link
Member

@guberti guberti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, merging this.

@guberti guberti merged commit bd3d93b into apache:main Jan 12, 2023
fzi-peccia pushed a commit to fzi-peccia/tvm that referenced this pull request Mar 27, 2023
* Remove tutorials CMSIS dependencies when not needed

Change-Id: Ic844422c74855f774b97ea57c6cb6eac2236e29b

* Address comments

Change-Id: Idbaada0753a9d46cfd94f71fcb30c7f7a8a1d17d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants