Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MeteSchedule] Bugfix: Add checks for nullable run_secs #13790

Merged
merged 1 commit into from
Jan 16, 2023
Merged

[MeteSchedule] Bugfix: Add checks for nullable run_secs #13790

merged 1 commit into from
Jan 16, 2023

Conversation

spectrometerHBH
Copy link
Contributor

@spectrometerHBH spectrometerHBH commented Jan 16, 2023

Runner sec is an Optional ObjectRef, so we need to check it's defined before we access its value.

@tvm-bot
Copy link
Collaborator

tvm-bot commented Jan 16, 2023

Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.

  • No users to tag found in teams: meteschedule See #10317 for details

Generated by tvm-bot

Copy link
Member

@junrushao junrushao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Please add some commit message :-)

@junrushao junrushao changed the title [Fix] runner sec value accquired before checked [MeteSchedule] Bugfix: Add checks for nullable run_secs Jan 16, 2023
Runner sec is an Optional ObjectRef, so we need to check it's defined before we access its value.
@junrushao junrushao merged commit b0b8d3e into apache:main Jan 16, 2023
csullivan pushed a commit to csullivan/tvm that referenced this pull request Feb 7, 2023
Runner sec is an Optional ObjectRef, so we need to check it's defined before we access its value.
fzi-peccia pushed a commit to fzi-peccia/tvm that referenced this pull request Mar 27, 2023
Runner sec is an Optional ObjectRef, so we need to check it's defined before we access its value.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants