[TVMScript] Use TVMScript for all TIR Printing #13795
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.
Generated by tvm-bot |
junrushao
force-pushed
the
feature/2023-01-16/tvmscript-migration
branch
9 times, most recently
from
5f1cf90 to
6fb1aa9
Compare
junrushao
changed the title
junrushao
force-pushed
the
feature/2023-01-16/tvmscript-migration
branch
5 times, most recently
from
a92d783 to
bc6e21b
Compare
This PR clarifies TVMScript is the only possible format for TIR printing by default. To do this, the PR makes the following changes: - `AsText` and `PrettyPrint` are moved to Relay, so that in code, it stresses that they are specifically used for non-TIR usecases - The use of legacy behavior, for example, `TIRTextPrinterDebug`, `PrettyPrint`, `AsText`, `AsLegacyRepr`, are still available in both C++ and Python, but are discouraged in a way that one needs to include extra headers. - `astext` method is removed from TIR nodes, but remain available for Relay and others
junrushao
force-pushed
the
feature/2023-01-16/tvmscript-migration
branch
from
bc6e21b to
0f31975
Compare
spectrometerHBH
approved these changes
Jan 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR clarifies TVMScript is the only possible format for TIR printing
by default. To do this, the PR makes the following changes:
AsTextandPrettyPrintare moved to Relay, so that in code, itstresses that they are specifically used for non-TIR usecases
TIRTextPrinterDebug,PrettyPrint,AsText,AsLegacyRepr, are still available in bothC++ and Python, but are discouraged in a way that one needs to include
extra headers.
astextmethod is removed from TIR nodes, but remain available forRelay and others