Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Unity][CI] setup CI (do not upstream to main) #13902

Closed
wants to merge 4 commits into from

Conversation

YuchenJin
Copy link
Contributor

Set up CI to run Relax tests.

@tvm-bot
Copy link
Collaborator

tvm-bot commented Feb 2, 2023

Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.

Generated by tvm-bot

@Mousius
Copy link
Member

Mousius commented Feb 2, 2023

@YuchenJin because you're always launching the instances and then exiting, you'd incur the minimum charge of 60 seconds for the instances you're running even if you don't use any of the compute - might be better to turn off the builds in github somewhere?

@YuchenJin
Copy link
Contributor Author

@YuchenJin because you're always launching the instances and then exiting, you'd incur the minimum charge of 60 seconds for the instances you're running even if you don't use any of the compute - might be better to turn off the builds in github somewhere?

Thanks for the suggestion! The main reason for adding exit 0 to a bunch of scripts is to avoid the complication when rebasing against the main branch, and we don't need to modify the jenkins while reusing the current tvm jenkins ci setting.
Would love to hear others' thoughts: @driazati @areusch

@@ -17,6 +17,9 @@
# under the License.
set -euxo pipefail

# SKIP: DO NOT UPSTREAM TO MAIN
exit 0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you move this logic into the Jenkins scripts themselves before any node(...) calls are made? Doing it here still allocates machines, runs the docker setup, etc. which is not that much but expensive to end up doing nothing

@tqchen
Copy link
Member

tqchen commented Feb 3, 2023

#13910 should achieve the asks that leverages a customized jenkins setup and skip most of the existing pipelines without starting a stage

@YuchenJin
Copy link
Contributor Author

#13910 should achieve the asks that leverages a customized jenkins setup and skip most of the existing pipelines without starting a stage

Thanks!

@YuchenJin YuchenJin closed this Feb 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants