Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TIR][Analysis] Implement IdentifyMemCpy analysis function #13947
[TIR][Analysis] Implement IdentifyMemCpy analysis function #13947
Changes from 7 commits
b3b383e
105fb8c
c3c39f9
f617960
d86c1a5
9d5dfcc
c55eaca
492caab
aec0e23
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a bit tricky to return the result and error message at the same time. An alternate way is to raise a specific exception and catch from outside.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed, though I think the
std::variant
avoids most of the usual issues. Rather than returning both the result and the error message at the same time, it returns either the result or the error message, but never both. I didn't want to throw an exception, as I expect the "error" case to be much more common, which is why the public-facing API exposes astd::optional<MemCpyDetails>
instead of the internal variant.