[TVMScript] Deterministic function ordering #13962
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment. Generated by tvm-bot |
tqchen
reviewed
Feb 11, 2023
| TVM_STATIC_IR_FUNCTOR(IRDocsifier, vtable) | ||
| .set_dispatch<IRModule>("", [](IRModule mod, ObjectPath p, IRDocsifier d) -> Doc { | ||
| std::vector<std::pair<GlobalVar, BaseFunc>> functions{mod->functions.begin(), | ||
| mod->functions.end()}; | ||
| // print "main" first | ||
| std::sort(functions.begin(), functions.end(), [](const auto& lhs, const auto& rhs) { | ||
| String lhs_name = lhs.first->name_hint; | ||
| String rhs_name = rhs.first->name_hint; | ||
| if (lhs_name == "main") { |
There was a problem hiding this comment.
nit: we can cache sort key by generating a tuple first then sort instead of doing string look up compare each time.
There was a problem hiding this comment.
Thanks! Updated accordingly
This PR makes IRModule printing deterministic by fix the function ordering. The "main" function always comes last, while other functions should be ordered alphabetically.
junrushao
force-pushed
the
feature/2023-02-11/irmodule-func-ordering
branch
from
8ddf6c1 to
adbf1f0
Compare
tqchen
approved these changes
Feb 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes IRModule printing deterministic by fix the function ordering. The "main" function always comes last, while other functions should be ordered alphabetically.