Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WEB] Reduce memleak in web runtime #14086

Merged
merged 1 commit into from
Feb 22, 2023
Merged

Conversation

tqchen
Copy link
Member

@tqchen tqchen commented Feb 22, 2023

This PR robustifies the web runtime to reduce memory leak
and enhances the runtime with object support.

Specifically we introduce scoping and auto-release
mechanism when we exit the scope. The improvements
are helpful to deal with memory leak in wasm and webgpu settings.

@tvm-bot
Copy link
Collaborator

tvm-bot commented Feb 22, 2023

Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.

  • No users to tag found in teams: web See #10317 for details

Generated by tvm-bot

@tqchen tqchen force-pushed the webupdate branch 2 times, most recently from 50a89aa to 2a7ec11 Compare February 22, 2023 15:06
@tqchen tqchen changed the title [WEB] Reduce memleak in web runtime. [WEB] Reduce memleak in web runtime Feb 22, 2023
This PR robustifies the web runtime to reduce memory leak
and enhances the runtime with object support.

Specifically we introduce scoping and auto-release
mechanism when we exit the scope. The improvements
are helpful to deal with memory leak in wasm and webgpu settings
Copy link
Contributor

@MasterJH5574 MasterJH5574 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@MasterJH5574 MasterJH5574 merged commit 1e988a4 into apache:main Feb 22, 2023
yongwww pushed a commit to yongwww/tvm that referenced this pull request Feb 27, 2023
This PR robustifies the web runtime to reduce memory leak
and enhances the runtime with object support.

Specifically we introduce scoping and auto-release
mechanism when we exit the scope. The improvements
are helpful to deal with memory leak in wasm and webgpu settings
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants