[TVMScript] Use new variable frame in If/Then/Else #14250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, while TVMScript introduces a new scope for other contexts (e.g. `for`, `while`, `with`, etc), the `if` and `else` blocks did not introduce a new scope. This caused erroneous parsing errors if the `if` and `else` blocks each contained a variable with the same name. Added a `self.var_table.with_frame()` context resolves this issue.
|
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.
Generated by tvm-bot |
junrushao
approved these changes
Mar 19, 2023
There was a problem hiding this comment.
Looks like a nice enhancement! LGTM. @wrongtest-intellif could you take a look?
|
I do believe this is good to merge. @wrongtest-intellif what do you think? |
|
Thank you, @junrushao! Merged main into the PR branch to resolve conflicts, so it'll be ready for merge. |
|
Thanks @Lunderberg!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, while TVMScript introduces a new scope for other contexts (e.g.
for,while,with, etc), theifandelseblocks did not introduce a new scope. This caused erroneous parsing errors if theifandelseblocks each contained a variable with the same name. Added aself.var_table.with_frame()context resolves this issue.