Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[skip ci] Replace magic_wand model with micro_speech #14414

Merged
merged 4 commits into from
Mar 29, 2023

Conversation

Aleksei-grovety
Copy link
Contributor

@Aleksei-grovety Aleksei-grovety commented Mar 28, 2023

Model magic_wand was replaced by model micro_speech since model magic_wand was removed in the commit. Also added commit's sha to the link to avoid this issue in the future.

cc @mehrdadh

@tvm-bot
Copy link
Collaborator

tvm-bot commented Mar 28, 2023

Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.

  • No users to tag found in teams: skip ci See #10317 for details

Generated by tvm-bot

@github-actions github-actions bot requested a review from mehrdadh March 28, 2023 09:29
@mehrdadh
Copy link
Member

@Aleksei-grovety could you please add the commit sha to the link so we avoid this issue in future? Also to update a link we need to also upload it in S3. I can help you with that if you post the link here.

@Aleksei-grovety
Copy link
Contributor Author

Aleksei-grovety commented Mar 29, 2023

@Aleksei-grovety could you please add the commit sha to the link so we avoid this issue in future? Also to update a link we need to also upload it in S3. I can help you with that if you post the link here.

The link is https://github.com/tensorflow/tflite-micro/raw/a56087ffa2703b4d5632f024a8a4c899815c31bb/tensorflow/lite/micro/examples/micro_speech/micro_speech.tflite
I chose commit sha with the latest model changes.

@Aleksei-grovety Aleksei-grovety changed the title [microTVM] Fix link to magic_wand model [skip ci] Replace magic_wand model with micro_speech Mar 29, 2023
Copy link
Contributor

@lhutton1 lhutton1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Aleksei-grovety LGTM! I don't think the [skip ci] functionality worked, but given the changes it would be good to get them verified anyway

Copy link
Member

@mehrdadh mehrdadh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!
Just to double check, did you already upload the model to S3?

@masahi
Copy link
Member

masahi commented Mar 29, 2023

skip-ci is not working since the commit message doesn't start skip-ci as well.

Link to the model was replaced with a link before it was removed from the repositoryhttps://github.com/tensorflow/tflite-micro/commit/bef8fe8bc6183cc4e1ce852579abcb7a171f8a5c
@driazati driazati force-pushed the fix-micro-tvmc-how-to branch from 26e2925 to 037dd46 Compare March 29, 2023 19:07
@driazati
Copy link
Member

Looks like Jenkins got stuck on something, I rebased this and added [skip ci] so we can get this merged

@mehrdadh mehrdadh merged commit 0ded213 into apache:main Mar 29, 2023
@Aleksei-grovety
Copy link
Contributor Author

LGTM, thanks! Just to double check, did you already upload the model to S3?

I didn't, someone uploaded the model.

@mehrdadh
Copy link
Member

@Aleksei-grovety
Copy link
Contributor Author

Thanks @mehrdadh!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants