-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[skip ci] Replace magic_wand model with micro_speech #14414
Conversation
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.
Generated by tvm-bot |
@Aleksei-grovety could you please add the commit sha to the link so we avoid this issue in future? Also to update a link we need to also upload it in S3. I can help you with that if you post the link here. |
The link is https://github.com/tensorflow/tflite-micro/raw/a56087ffa2703b4d5632f024a8a4c899815c31bb/tensorflow/lite/micro/examples/micro_speech/micro_speech.tflite |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Aleksei-grovety LGTM! I don't think the [skip ci]
functionality worked, but given the changes it would be good to get them verified anyway
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Just to double check, did you already upload the model to S3?
|
Link to the model was replaced with a link before it was removed from the repositoryhttps://github.com/tensorflow/tflite-micro/commit/bef8fe8bc6183cc4e1ce852579abcb7a171f8a5c
…escription in micro_tvmc.sh
26e2925
to
037dd46
Compare
Looks like Jenkins got stuck on something, I rebased this and added |
I didn't, someone uploaded the model. |
@Aleksei-grovety yeah I added it here: https://github.com/apache/tvm/actions/runs/4555724050 |
Thanks @mehrdadh! |
Model magic_wand was replaced by model micro_speech since model magic_wand was removed in the commit. Also added commit's sha to the link to avoid this issue in the future.
cc @mehrdadh