[pytest] Don't return values from test_* functions #14475
Conversation
Pytest expects test functions to return None, and errors to be flagged via exceptions. It actually emits warnings for "return" statements encountered in test_ functions.
|
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.
Generated by tvm-bot |
There was a problem hiding this comment.
Thank you for the catch, and looks good to me! If I recall correctly, these were initially intended to reduce duplication between some of the tests and the test fixtures, as a workaround for pytest's lack of subtests, but I missed the return statements in pre-PR cleanup.
| @@ -151,7 +151,7 @@ def test_maxpool(self, shape_nhwc, window_size, stride, pad, dtype, target): | |||
| padding=(pad, pad, pad, pad), | |||
| dtype=dtype, | |||
| ) | |||
| return output, ref_output | |||
| assert all([output is not None, ref_output is not None]) | |||
There was a problem hiding this comment.
If the assert is causing spurious unit test failures, it can be removed. The test is to ensure that no exceptions are through while lowering/building, and no further assert is required.
There was a problem hiding this comment.
I did remove it at first, but then the linter complained that output and ref_output were unused values... :|
There was a problem hiding this comment.
Ah, got it. So long as the build_and_run function is called in the test, the return value should be ignoreable here.
Pytest expects test functions to return None, and errors to be flagged via exceptions. It actually emits warnings for "return" statements encountered in test_ functions.