Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TIR] [Schedule] Add get_output_blocks primitive #14490

Merged
merged 4 commits into from
Apr 6, 2023

Conversation

quic-sanirudh
Copy link
Contributor

When scheduling fused ops, its really useful to be able to get all the output blocks and schedule other blocks in the fused op with respect to output blocks. This helps avoid hardcoding block names in manually written schedules in many cases

When scheduling fused ops, its really useful to be able to get all the
output blocks and schedule other blocks in the fused op with respect to
output blocks. This helps avoid hardcoding block names in manually
written schedules in many cases
@tvm-bot
Copy link
Collaborator

tvm-bot commented Apr 4, 2023

Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.

Generated by tvm-bot

@quic-sanirudh
Copy link
Contributor Author

cc @Hzfengsy @junrushao @vinx13

@quic-sanirudh
Copy link
Contributor Author

@tvm-bot rerun

@quic-sanirudh
Copy link
Contributor Author

one more attempt to get cross-isa-minimal working
@tvm-bot rerun

@quic-sanirudh
Copy link
Contributor Author

@tvm-bot rerun

This commit updates the primitive to take scope block as argument and
return all output blocks under that scope. In order to get all output
blocks of a PrimFunc, the root block can be passed
@quic-sanirudh quic-sanirudh requested a review from Hzfengsy April 5, 2023 10:49
@Hzfengsy
Copy link
Member

Hzfengsy commented Apr 5, 2023

Thanks @quic-sanirudh for the continuous improvement. Let's merge it when the ci is green

@quic-sanirudh
Copy link
Contributor Author

@tvm-bot rerun

@kparzysz-quic kparzysz-quic merged commit 5239ec0 into apache:main Apr 6, 2023
@quic-sanirudh quic-sanirudh deleted the add_get_output_blocks branch April 6, 2023 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants