Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LLVM][RUNTIME] Enable multi systemlib with device code #14843

Merged
merged 1 commit into from
May 13, 2023

Conversation

tqchen
Copy link
Member

@tqchen tqchen commented May 12, 2023

This PR enables combination of multiple system lib into the same static library with a system_lib_prefix attribute. This can open doors for multiple models to be compiled separately then packaged into the same app via static library.

It resolves a previous issue that prevents multiple system lib to be linked together when they come with extra binary component such as CUDA due to symbol conflict.

@tvm-bot
Copy link
Collaborator

tvm-bot commented May 12, 2023

Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.

Generated by tvm-bot

Copy link
Member

@junrushao junrushao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Please fix the CI failure

This PR enables combination of multiple system lib
into the same static library with a system_lib_prefix attribute.
This can open doors for multiple models to be compiled separately
then packaged into the same app via static library.

It resolves a previous issue that prevents multiple system
lib to be linked together when they come with extra binary component
such as CUDA due to symbol conflict.
@junrushao junrushao merged commit 05001be into apache:main May 13, 2023
masahi pushed a commit to masahi/tvm that referenced this pull request May 13, 2023
This PR enables combination of multiple system lib
into the same static library with a system_lib_prefix attribute.
This can open doors for multiple models to be compiled separately
then packaged into the same app via static library.

It resolves a previous issue that prevents multiple system
lib to be linked together when they come with extra binary component
such as CUDA due to symbol conflict.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants