[Bugfix][PyTorch] Support use_input_stats in instance_norm #14963
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shingjan
reviewed
May 26, 2023
| @@ -1385,6 +1385,9 @@ def instance_norm(self, inputs, input_types): | |||
| data = inputs[0] | |||
| data_type = input_types[0] | |||
| channels = self.infer_shape(data) | |||
| running_mean = inputs[3] | |||
There was a problem hiding this comment.
Is this a most recent api change from pytorch or a long ignored params on our side? The former will need us to think about BC.
There was a problem hiding this comment.
The latter I think. The "track_running_stats" has been ignored in the unit test.
By the way, there will be another PR later about BC, also on a similar issue.
masahi
approved these changes
May 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #14926 .
The input should be normalized with the provided running mean and running variance instead of computing the mean and variance from the input data when use_input_stats is set to false.