[Docker] Migrate arm docker image to use llvm packages #15067
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.
Generated by tvm-bot |
lhutton1
reviewed
Jun 12, 2023
There was a problem hiding this comment.
Thanks @neildhickey! Perhaps it would be good to also mention the version change (15->16) in the commit message for more visibility? Otherwise LGTM
ci_arm was building llvm from source but this should no longer be required now we've update to Ubuntu 20.04 This also updates arm llvm package to 16
neildhickey
force-pushed
the
arm_llvm_from_package
branch
from
e2f83e4 to
3e2015e
Compare
|
@tvm-bot rerun |
1 similar comment
|
@tvm-bot rerun |
|
Thanks @neildhickey! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ci_arm was building llvm from source but this should no longer be required now we've update to Ubuntu 20.04