Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Frontend][Relay][Keras] Fix concatenate convert function in axis parsing #15175

Merged
merged 16 commits into from
Jul 1, 2023
Merged

[Frontend][Relay][Keras] Fix concatenate convert function in axis parsing #15175

merged 16 commits into from
Jul 1, 2023

Conversation

jikechao
Copy link
Contributor

@jikechao jikechao commented Jun 28, 2023 •
edited
Loading

This pr fixed the bug in #15174 and added some specific test cases for Concatenate operator.

cc @echuraev @Hzfengsy

@tvm-bot
Copy link
Collaborator

tvm-bot commented Jun 28, 2023 •
edited
Loading

Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.

Generated by tvm-bot

@github-actions github-actions bot requested review from Hzfengsy and echuraev June 28, 2023 02:41
@jikechao jikechao changed the title [Frontend][Keras][Keras] Fix concatenate convert function in axis parsing [Frontend][Relay][Keras] Fix concatenate convert function in axis parsing Jun 28, 2023
@jikechao jikechao marked this pull request as draft June 28, 2023 05:48
@jikechao jikechao marked this pull request as ready for review June 29, 2023 06:48
@jikechao
Copy link
Contributor Author

The newly added test cases cannot pass the CI test. However, It can run well in my local environment. So wired it is.

@Hzfengsy
Copy link
Member

Is it related to the Karas version?

@jikechao
Copy link
Contributor Author

@Hzfengsy @junrushao Thanks for your comments and review.
My patch was incomplete and It only considered the layout as 'NHWC'. The CI failed when layout = 'NCHW' for the input will be transposed. I have corrected the patches. Could you help me review it again? Thanks again!

echuraev
echuraev approved these changes Jun 30, 2023
View reviewed changes
Copy link
Contributor

@echuraev echuraev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks.

@jikechao
Copy link
Contributor Author

@echuraev Thanks for your review.

@jikechao
Copy link
Contributor Author

jikechao commented Jul 1, 2023

@tvm-bot rerun

@tqchen tqchen merged commit e178375 into apache:main Jul 1, 2023
@ysh329 ysh329 mentioned this pull request Jul 12, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@junrushao junrushao junrushao approved these changes

@echuraev echuraev echuraev approved these changes

@Hzfengsy Hzfengsy Awaiting requested review from Hzfengsy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@jikechao @tvm-bot @Hzfengsy @echuraev @junrushao @tqchen