[MetaSchedule] Fix metaschedule flop estimation for non-integer loop dimensions #15574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.
Generated by tvm-bot |
Hzfengsy
reviewed
Aug 16, 2023
|
|
||
|
|
||
| def test_flops_with_nonint_extent(): | ||
| estimate_tir_flops(IRModule({"main": flops_with_nonint_extent})) |
There was a problem hiding this comment.
Please check the return value, e.g assert flops == 8
There was a problem hiding this comment.
Thank you for the feedback! Assertions have been added.
Hzfengsy
approved these changes
Aug 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Estimates the loop range using arith::Analyzer, starting from the outermost loop.
Added appropriate test cases.
This is a code patch for fixing this issue: #12139