Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLI TOOLS][RTVM] Improve rtvm tool with new options to measure native performance #15818

Merged
merged 3 commits into from
Sep 29, 2023

Conversation

srkreddy1238
Copy link
Contributor

Few fixes and enhancements that affects model loading times New options to measure performance.

Few fixes and enhancements that affects model loading times
New options to measure performance.
@srkreddy1238 srkreddy1238 changed the title [RTVM] Improve rtvm tool with new options to measure native performance [CLI TOOLS][RTVM] Improve rtvm tool with new options to measure native performance Sep 26, 2023
Copy link
Contributor

@echuraev echuraev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your PR! Just a couple of small comments

apps/cpp_rtvm/main.cc Show resolved Hide resolved
apps/cpp_rtvm/tvm_runner.cc Outdated Show resolved Hide resolved
apps/cpp_rtvm/main.cc Outdated Show resolved Hide resolved
@srkreddy1238
Copy link
Contributor Author

@echuraev There are some requirements and concerns on high load and unload timings with TVM in general. With PreCompiled bin we could reduce the majority and there exist some more scope with params loading. Unload time is also a bit significant. I am working on few improvements around these areas ...

Copy link
Contributor

@echuraev echuraev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! @srkreddy1238 just up to you if you want to return dynamic allocation or not. Feel free to merge this PR when the CI is green.

apps/cpp_rtvm/main.cc Outdated Show resolved Hide resolved
@srkreddy1238
Copy link
Contributor Author

srkreddy1238 commented Sep 28, 2023

Never mind. While I was relooking into the code I found a reference of the deleted object and fixed it.

@srkreddy1238 srkreddy1238 merged commit def551d into apache:main Sep 29, 2023
@srkreddy1238 srkreddy1238 deleted the rtvm_perf_options branch September 29, 2023 05:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants