[Unity] Move VarBinding's and MatchCast's value to base class #15992
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this commit, the `VarBinding` and `MatchCast` had equivalent `Expr value` fields. For use cases that need the bound value (e.g. collecting known values), this required downcasting to each subclass. This commit moves the `Expr value` to the base `Binding` class, removing the need for the downcasting. No impact to either C++ or Python usage is expected. On the C++ side, all use of `VarBindingNode::value` or `MatchCastNode::value` will now access `BindingNode::value`. On the Python side, all dynamic access of `binding_obj.value` will access the new field.
|
@slyubomirsky I was thinking about the |
tqchen
requested changes
Oct 29, 2023
| @@ -796,9 +798,6 @@ class MatchCast : public Binding { | |||
|
|
|||
| class VarBindingNode : public BindingNode { | |||
| public: | |||
| /*! \brief The binding value. */ | |||
| Expr value; | |||
There was a problem hiding this comment.
We intentionally keep the value in the subclass, because in match clas there is extra set of struct info to be considered(that can populates new values), and it is important to keep reminding the users of this.
The extra dispatch is worth overall for this explicitness
There was a problem hiding this comment.
Good point, and closing this PR.
15 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit, the
VarBindingandMatchCasthad equivalentExpr valuefields. For use cases that need the bound value (e.g. collecting known values), this required downcasting to each subclass. This commit moves theExpr valueto the baseBindingclass, removing the need for the downcasting.No impact to either C++ or Python usage is expected. On the C++ side, all use of
VarBindingNode::valueorMatchCastNode::valuewill now accessBindingNode::value. On the Python side, all dynamic access ofbinding_obj.valuewill access the new field.