[Hotfix] Revert driver API pass ordering that breaks MLC, mark failing test #16770
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 22, 2024
Lunderberg
approved these changes
Mar 22, 2024
| @@ -482,6 +482,12 @@ def simple_compute( | |||
| assert generated_code == expected_cuda_script | |||
|
|
|||
|
|
|||
| @pytest.mark.skip( | |||
There was a problem hiding this comment.
I like the documentation, both to indicate what needs to be resolved in order to re-enable functionality, and where the existing discussions are
slyubomirsky
changed the title
|
Tianqi clarified that only the driver API pass ordering caused the MLC failures, so that's the only change being reverted here now. |
MasterJH5574
approved these changes
Mar 22, 2024
There was a problem hiding this comment.
Thanks so much @slyubomirsky @Lunderberg @tqchen. Just checked on my local side: this PR can fix the model compilation error.
tqchen
approved these changes
Mar 22, 2024
|
The CI error looks to be spurious. We will have to retrigger it. |
|
@tvm-bot rerun |
thaisacs
pushed a commit
to thaisacs/tvm
that referenced
this pull request
Apr 3, 2024
…g test (apache#16770) * Revert changes that cause failures in MLC, mark and skip the failing tests * Restore changes unrelated to driver API reordering
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following up from discussion in #16769, this is a smaller-scale reversion that patches the MLC build by reverting only the changes that broke it (the driver API pass reordering). However, these changes came from #16569 and were needed to fix failing tests. That test has been marked as skippable here but should be fixed along with MLC.