Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Relax][VM] Refactor CUDA graph builtins as VM extension #16823

Merged
merged 4 commits into from
Apr 1, 2024

Conversation

vinx13
Copy link
Member

@vinx13 vinx13 commented Mar 29, 2024

This PR introduce VM extension, which allow users to define target related runtime extensions. The VM holds the reference to the extension once created to ensure it is destructed at VM destruction.

CUDA graph builtins are refactored as VM extension to make the cuda graph cache per-VM instead of per-thread, to allow VM to be run on different threads (non-concurrently).

This PR need rebase after #16815

cc @tqchen

@github-actions github-actions bot requested a review from tqchen March 29, 2024 23:01
@vinx13 vinx13 force-pushed the feat/cuda-graph-extension branch from e51c08f to e96d46c Compare March 30, 2024 21:53
@vinx13 vinx13 force-pushed the feat/cuda-graph-extension branch from e96d46c to 287a10a Compare March 30, 2024 23:14
@tqchen
Copy link
Member

tqchen commented Apr 1, 2024

@vinx13 let us disable the failed hexagon test first, since it seems to be a flaky one

@Lunderberg
Copy link
Contributor

Thank you for mentioning the failed hexagon test. I have the same one failing in #16543, where the changes made are similarly unrelated to Hexagon. CI link

@tqchen tqchen merged commit fc78b22 into apache:main Apr 1, 2024
19 checks passed
thaisacs pushed a commit to thaisacs/tvm that referenced this pull request Apr 3, 2024
* [Relax][VM] Refactor CUDA graph builtins as VM extension

* skip test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants