Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overriding the StructuralEqual() for easy usage #16908

Merged
merged 4 commits into from
Apr 30, 2024

Conversation

sdalvi-quic
Copy link
Contributor

Override the StrucutralEqual operator () to ensure easy usage of the function.

@jverma-quic and @quic-sanirudh can you please take a look.

Copy link
Contributor

@quic-sanirudh quic-sanirudh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but please fix the lint errors.

@quic-sanirudh
Copy link
Contributor

@tvm-bot rerun

2 similar comments
@sdalvi-quic
Copy link
Contributor Author

@tvm-bot rerun

@quic-sanirudh
Copy link
Contributor

@tvm-bot rerun

@sdalvi-quic sdalvi-quic force-pushed the sdalvi/StructuralEq_override branch from bd2af20 to b9b452b Compare April 29, 2024 16:36
Copy link
Contributor

@jverma-quic jverma-quic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@quic-sanirudh quic-sanirudh merged commit c8deb7f into apache:main Apr 30, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants