[Disco] Implement num_workers property for disco.Session
#16978
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
masahi
approved these changes
May 13, 2024
|
@Lunderberg Need to resolve the conflict. |
Prior to this commit, while the `num_workers` argument was provided to the `disco.Session` object, it could not be determined from an existing `disco.Session` object. As a result, functions that interacted with a multi-GPU setup frequently required separate `num_workers` and `disco_session` argument, which could erroneously be out-of-sync (e.g. passing the incorrect `num_workers`, or omitting the `disco_session` argument when `num_workers>1`). To remove this class of errors, this commit adds a `disco.Session.num_workers` property. The separate `num_workers` argument is no longer necessary, as it can be determined from the `disco.Session` instance.
Lunderberg
force-pushed
the
disco_num_workers_property
branch
from
c1788e7 to
317f062
Compare
|
Thank you, and conflict resolved! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit, while the
num_workersargument was provided to thedisco.Sessionobject, it could not be determined from an existingdisco.Sessionobject. As a result, functions that interacted with a multi-GPU setup frequently required separatenum_workersanddisco_sessionargument, which could erroneously be out-of-sync (e.g. passing the incorrectnum_workers, or omitting thedisco_sessionargument whennum_workers>1).To remove this class of errors, this commit adds a
disco.Session.num_workersproperty. The separatenum_workersargument is no longer necessary, as it can be determined from thedisco.Sessioninstance.