Skip to content

[Web] Add dtype and offset for CreateView in runtime #17028

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tqchen merged 1 commit into from
May 26, 2024
Merged

[Web] Add dtype and offset for CreateView in runtime #17028

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions web/src/runtime.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -519,11 +519,20 @@ export class NDArray implements Disposable {
/**
* Create a view of the array.
* @param shape The shape of the view.
* @param dtype The data type of the new array.
* @returns The new sliced ndarray.
*/
view(shape: Array<number>): NDArray {
view(shape: Array<number>, dtype?: string): NDArray {
const shapeArray = shape.map((value) => new Scalar(value, "int"));
return this.ctx.ndarrayCreateView(this, this.ctx.makeShapeTuple(...shapeArray));
if (dtype === undefined) {
dtype = this.dtype;
}
return this.ctx.ndarrayCreateView(
this,
this.ctx.makeShapeTuple(...shapeArray),
this.dtype,
/*relative_byte_offset=*/ new Scalar(0, "int"),
);
}

/**
Expand Down