-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TIR][Schedule] Remove @type_check
for set_axis_separator
#17134
Conversation
The decorator is not allowing types like Array to be passed to set_axis_separator directive. The FFI has a type checking implemented internally making this redundant.
@tvm-bot rerun |
cc: @Lunderberg |
@type_check
decorator for set_axis_separator
@type_check
for set_axis_separator
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the follow-up, and this change looks good! I like the consolidation of the type-checking into the FFI.
Thank you @Lunderberg for reviewing this change! |
If they are being checked in the FFI, then that would be fantastic, thank you! The main thing to watch out for is C++ functions that use |
Sure. I will work on this and try to check how much more type checks can be moved to FFI in a new PR. Would it be okay to merge this PR ? |
Array
to be passed to set_axis_separator directive.input_axis_separator
to allow 2D to 1D conversion #17115