[Transform][Relax] Handle is_group argument in IPC AllReduce
#17201
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `relax.transform.IPCAllReduceRewrite` pass rewrites calls to `"runtime.disco.allreduce"` to instead call an optimized `"runtime.disco.cuda_ipc.custom_allreduce"` version. When the legalization of `R.ccl.allreduce` was updated in apache#17180 to provide an `in_group` argument, the `IPCAllReduceRewrite` pass was not updated. This commit updates the `IPCAllReduceRewrite` to be handle the additional `in_group` argument.
MasterJH5574
approved these changes
Jul 26, 2024
Contributor
MasterJH5574
left a comment
MasterJH5574
left a comment
There was a problem hiding this comment.
Thank you @Lunderberg for catching this!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
relax.transform.IPCAllReduceRewritepass rewrites calls to"runtime.disco.allreduce"to instead call an optimized"runtime.disco.cuda_ipc.custom_allreduce"version. When the legalization ofR.ccl.allreducewas updated in #17180 to provide anin_groupargument, theIPCAllReduceRewritepass was not updated.This commit updates the
IPCAllReduceRewriteto be handle the additionalin_groupargument.