Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix][LLVM] Fix getHostCPUFeatures LLVM version cutoff #17403

Merged
merged 1 commit into from
Sep 23, 2024
Merged

[Fix][LLVM] Fix getHostCPUFeatures LLVM version cutoff #17403

merged 1 commit into from
Sep 23, 2024
+1 −1

Commits on Sep 22, 2024

  1. [Fix][LLVM] Fix getHostCPUFeatures LLVM version cutoff 

    This PR fixes the LLVM version cutoff for `llvm::sys::getHostCPUFeatures`.
Previously the cutoff version is set to 20.0, assuming that the
signature change happens since LLVM 20.0.
While actually the signature change happens at 19.0.

Reference:
* LLVM 18.1.8 https://github.com/llvm/llvm-project/blob/llvmorg-18.1.8/llvm/include/llvm/TargetParser/Host.h#L56
* LLVM 19.1.0 https://github.com/llvm/llvm-project/blob/llvmorg-19.1.0-rc1/llvm/include/llvm/TargetParser/Host.h#L55
    @MasterJH5574
    MasterJH5574 authored Sep 22, 2024
    Configuration menu
    Copy the full SHA
    6e71724 View commit details
    Browse the repository at this point in the history