[Refactor] Phaseout python dependency package decorator
#17652
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@tvm-bot rerun |
Contributor
|
Failed to re-run CI in https://github.com/apache/tvm/actions/runs/13333204874 Detailswith response |
Member
|
would be great if the pr remove the merge branch commit and focus on the rebase |
LeiWang1999
force-pushed
the
phaseout_decorator
branch
from
6050aaa to
b61a996
Compare
- Remove attrs from base requirements and constraints - Replace attr.s decorator with @DataClass in memory_plan.py - Simplify Region class definition using dataclass Remove attrs dependency from installation scripts and documentation - Remove attrs from conda recipe requirements - Remove attrs from Docker installation scripts for Ubuntu - Update documentation to remove attrs from pip install instructions lint fix Remove decorator dependency from various installation scripts and files This commit removes the decorator package from: - Conda recipe requirements - Docker installation scripts - Python requirements generation - Documentation installation instructions Additionally, it introduces a local implementation of the decorator module in the TVM project to maintain existing functionality without external dependency. Refactor decorator module to remove external dependency This commit completes the local implementation of the decorator module by: - Cleaning up license headers - Formatting code to improve readability - Preserving the full functionality of the original decorator library - Ensuring consistent code style with the rest of the TVM project Refactor decorator module: Code formatting and style improvements This commit continues the work of refactoring the decorator module by: - Applying consistent code formatting - Using double quotes for string literals - Improving code readability through whitespace and line breaks - Maintaining the module's existing functionality Disable all pylint checks in decorator module Modify pylint configuration to disable all checks for the decorator module, simplifying linting rules while maintaining the module's functionality. Add decorator.py to rat-excludes for package source tracking Exclude the downloaded package source file for the decorator module from license header checks, maintaining consistency with previous refactoring efforts around the decorator module. Update LICENSE and NOTICE for decorator module Add attribution and licensing details for the decorator module in LICENSE and NOTICE files. Update rat-excludes to reflect the package source tracking for the decorator module.
LeiWang1999
force-pushed
the
phaseout_decorator
branch
from
b61a996 to
8820aae
Compare
Contributor
Author
|
Sure, I’ve rebased the branch onto main and squashed these commits. |
Member
|
@tvm-bot rerun |
Contributor
|
Failed to re-run CI in https://github.com/apache/tvm/actions/runs/13358565751 Detailswith response |
tqchen
approved these changes
Feb 16, 2025
Member
|
likely due to recent update there are some timeout issue, would be great if we can raise a new pr, hopefully better with recent cleanups, sorry for the trouble |
Contributor
Author
|
closed as we should move onto another pr |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request focuses on removing the
decoratordependency from various parts of the codebase and updating the relevant files accordingly as the decorator package consists of a single file and has not been maintained for a long time.Codebase updates:
python/gen_requirements.py: Removeddecoratorfrom the base requirements and the list of additional requirements. [1] [2]python/tvm/_ffi/base.py: Replaced the usage of the externaldecoratorpackage with an internal implementation of thedecoratefunction.conda/recipe/meta.yaml: Removeddecoratorfrom the list of runtime dependencies.docker/Dockerfile.demo_opencl: Removeddecoratorfrom the list of Python packages installed viapip3.docker/install/ubuntu2004_install_python_package.sh: Removeddecoratorfrom the list of Python packages installed viapip3.docker/install/ubuntu_install_python_package.sh: Removeddecoratorfrom the list of Python packages installed viapip3.docs/install/from_source.rst: Updated the installation instructions to removedecoratorfrom the list of extra Python dependencies.