[Refactor] Improve TargetHasSVE function with optional target handling #17666
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Update TargetHasSVE to accept an optional Target parameter - Add default behavior to use current target if no target is specified - Simplify target checking logic in the function
LeiWang1999
changed the title
cbalint13
approved these changes
Feb 19, 2025
Contributor
|
Thanks @LeiWang1999 , it looks good to me. |
ShiboXing
pushed a commit
to ShiboXing/tvm
that referenced
this pull request
Aug 10, 2025
apache#17666) * Improve TargetHasSVE function with optional target handling - Update TargetHasSVE to accept an optional Target parameter - Add default behavior to use current target if no target is specified - Simplify target checking logic in the function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pull request #16893 refactored the TargetHasSVE function to support target assignment instead of using Target::Current(). This introduces a breaking API change for older projects that rely on TVM. However, the issue can be easily fixed by adding an Optional tag and a default value.