-
Notifications
You must be signed in to change notification settings - Fork 3.8k
[Relax][PyTorch] Add support for index_select #17787
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remaining TODOs Make sure that also works if we input a list of indices Write tests at the py and cpp level Cleanup
Contributor
Author
|
@tvm-bot rerun |
Contributor
Author
|
cc: @MasterJH5574 this is ready for review |
Contributor
Author
|
I deleted this branch by accident, which closed the PR. I reopened the same PR here #17790 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding support in the exported translator for index_select.default, which was already supported by the FX translator. This is in the hope that index_select will be useful for index.Tensor, which is more complex and not currently supported by the FX translator.